-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#1905 Add configure icons on public pages #17942
dev/core#1905 Add configure icons on public pages #17942
Conversation
(Standard links)
|
e046140
to
a7f41fd
Compare
@colemanw can you comment on this? |
this is very form layer so it doesn't need a a test. I'm still looking for a second opinion though. Perhaps if @colemanw doesn't get to it @agh1 or @MegaphoneJon might? |
Adding both is a bit much. Either button or Icon in my opinion. Not a deal breaker - it's good with me either way though! |
They configure different things... |
Good to know, that may not be immediately obvious. Not sure how we'd clarify that... |
If you hover on any icon/button the tooltip should be able to clarify. eg - I think we do this on all the icons present on the page? More related discussion is here - https://chat.civicrm.org/civicrm/pl/n3dzdtp9mf875kjzxc5pk3xmhh |
That's clear enough for me :-) |
OK - I'll go with @MikeyMJCO's review. I note there is a permission check so it's not showing for everyone & the code is straight forward |
Sorry I'm late to the party, but this PR wraps a lot of markup within |
dev/core#1905 rework #17942 with simpler ts strings
Overview
Add configure and priceset url icons on public contribution & event pages
Before
No Option to directly navigate to the configuration page or the priceset page used on the event or contribution
After
Configure and priceset icon is displayed on contribution and event pages.
Similarly for events.
Comments
Gitlab - https://lab.civicrm.org/dev/core/-/issues/1905