[REF] Reduce interaction between dedupe code and createProfileContact

[eileenmcnaughton]

Overview

Code cleanup in Dedupe function

Before

Problematic createProfileContact function called

After

A cut down version of the function called - with the goal to reduce further

Technical Details

Ideally we want to simply call apiv4 from the deduper. However, it seems to take a bit of analysis to determine
if anything is done in there that might have some impact. This takes one step in that direction. I copied the full function over
and then remove all the parts that are unreachable due to the passed in params or meaningless due to us not having Billing
fields. I think the Profile hooks are overkill - the merge hooks and contact hooks are being run and no profile is being submitted

Comments

@pfigel @JKingsnorth @demeritcowboy perhaps one of you can check this

Test cover should be pretty good

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I'm partly through this and this what I think you're saying:

• Billing_XXX fields from $params aren't relevant when merging, since it's not a form/profile being submitted it's already-existing contact records and the fields will be in their appropriate locations already. So can skip addBillingNameFieldsIfOtherwiseNotSet.
  • sure
• The hooks aren't relevant
  • This is maybe the one I'm least sure about, and where test coverage doesn't help since you're saying don't call these.
• The manage opt-out part is not needed because we already know $fields is blank.
  • Agree.
• Groups and tags are moved over some other way already.
  • ???
• The specific addToGroupID isn't relevant since we know it's blank.
  • Agree.
• Clear groupcontact cache doesn't need to be done here.
  • Not sure.

[eileenmcnaughton]

@demeritcowboy thanks!

So - groups & tags actually aren't touched in this function because $fields is NULL. In fact a recent change switches to checking $params but this would not have hit those lines

https://github.com/civicrm/civicrm-core/pull/17922/files#diff-c5e39924ad99ac88b48763a0d8fa246eR2024

GroupContactCache - is actually cleared in Contact.create - I'm working on a separate PR to remove it from that function

Re the change to not call the hooks - I can see a case for 'never change what has been done' - but on the other hand we are already calling contact pre & post hooks and dedupe hooks are there is no profile being submitted (as the hook implies). Perhaps @colemanw can weigh in (& potentially merge based on your feedback).

[colemanw]

I agree with you that the profile hooks are inappropriate to this scenario. This is good cleanup.