Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(POC, WIP) Extract Greenwich as an extension. Draft bootstrap.css variant. #17913

Closed
wants to merge 8 commits into from

Conversation

totten
Copy link
Member

@totten totten commented Jul 22, 2020

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Jul 22, 2020

(Standard links)

@civibot civibot bot added the master label Jul 22, 2020
</urls>
<releaseDate>2020-07-21</releaseDate>
<version>1.0</version>
<develStage>alpha</develStage>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep an eye on this alpha & not leave it at that

@colemanw
Copy link
Member

colemanw commented Aug 5, 2020

@totten could you please add some description to this PR?
I'm trying to figure out how to use it. I've applied the patch, enabled the extension, run composer install from within the civicrm/ext/greenwich directory. Now when I navigate to a bootstrap page like the APIv4 explorer... nothing different.
What else do I need to do to get bootstrap to load?

@eileenmcnaughton
Copy link
Contributor

@colemanw is the theme selected on the display preferences page?

@colemanw
Copy link
Member

colemanw commented Aug 5, 2020

@colemanw is the theme selected on the display preferences page?

Yes, I tried setting both the backend and frontend themes to "Greenwich (with Bootstrap)"

@totten
Copy link
Member Author

totten commented Sep 4, 2020

The approach is changing, so this PR is not needed.

@totten totten closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants