Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Fix a couple of jQuery errors that have cropped up #17871

Merged
merged 1 commit into from
Jul 17, 2020
Merged

[REF] Fix a couple of jQuery errors that have cropped up #17871

merged 1 commit into from
Jul 17, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes a couple of minor issues with jquery 1) size() is deprecated and 2) TypeError: e.indexOf is not a function coming up due to load() being deprecated

Before

Deprecated jQuery functions used

After

Non Deprecated jQuery functions used

ping @demeritcowboy @colemanw

@civibot
Copy link

civibot bot commented Jul 16, 2020

(Standard links)

@civibot civibot bot added the master label Jul 16, 2020
@seamuslee001 seamuslee001 mentioned this pull request Jul 16, 2020
Merged
@colemanw
Copy link
Member

Yep. Much better.

@eileenmcnaughton
Copy link
Contributor

very form layer so ok without test

@seamuslee001 seamuslee001 merged commit 881750c into civicrm:master Jul 17, 2020
@seamuslee001 seamuslee001 deleted the deprecated_jquery branch July 17, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass ok-without-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @colemanw @eileenmcnaughton