Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API tests - label versions in dataprovider versionThreeAndFour #17847

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

colemanw
Copy link
Member

Overview

In unit tests, make it more clear which api version is being tested.

Before

Numeric keys gave ambiguous messages like "Test xyz failed with dataset 0"

After

String keys should give more specific messages like "Test xyz failed with dataset 'APIv3'"

@civibot
Copy link

civibot bot commented Jul 15, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

(has-test = is test improvement)

@eileenmcnaughton eileenmcnaughton merged commit d9e0aea into civicrm:master Jul 15, 2020
@eileenmcnaughton eileenmcnaughton deleted the versionThreeAndFour branch July 15, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants