dev/core#1867 Ensure that the qill matches the filter when no time is… #17820

seamuslee001 · 2020-07-13T22:21:52Z

… supplied

Overview

This follows on from #17811 and fixes the text of the filter to match the actual filter when no time is specified

civibot · 2020-07-13T22:21:54Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

… supplied

eileenmcnaughton · 2020-07-13T22:24:36Z

@seamuslee001 better - but still reads odd due to the BETWEEN in this case being UNTIL - anyway that's a by-the-by. MOP

eileenmcnaughton · 2020-07-13T23:07:16Z

It would be good to test the qill but there isn't precedent for it & we shouldn't hold up a regression fix on a fairly heavy lift

civibot bot added the 5.28 label Jul 13, 2020

dev/core#1867 Ensure that the qill matches the filter when no time is…

20a120a

… supplied

seamuslee001 force-pushed the 1867_qill branch from fb4d166 to 20a120a Compare July 13, 2020 22:23

seamuslee001 mentioned this pull request Jul 13, 2020

dev/core#1867 Ensure that the qill matches the filter when no time is… #17821

Merged

eileenmcnaughton added merge on pass ok-without-test labels Jul 13, 2020

seamuslee001 merged commit 3655206 into civicrm:5.28 Jul 13, 2020

seamuslee001 deleted the 1867_qill branch July 13, 2020 23:24