dev/core#1865 Remove civiwp and option query strings from redirected …

[seamuslee001]

…url as they only relate to CiviCRM internal uses

Overview

This removes these additional query strings from the final redirected url as per dev/core#1865

Before

Some query strings that are only civi related passed onto the target url

After

only non civi related query strings passed onto the target url

ping @kcristiano @haystack @andrewpthompson

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

So this seems to have support from @kcristiano & @christianwach which indicates it is good from a WP point of view

I feel a little less clear how strong the endorsement is on the Joomla! front. I see you pinged @andrewpthompson - have any Joomla! peeps weighed in?

[seamuslee001]

test fail unrelated

[seamuslee001]

ping @lcdservices also

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Added merge ready because if @totten were standing by ready to release right now I'd be firmly in team 'better in than out' on this one.

[andrewpthompson]

I have had a look at this patch and it makes sense. I've tested it on Joomla and it works as expected, with the "option" parameter being removed from the redirected URL and no problems seen.

[eileenmcnaughton]

Thanks @andrewpthompson - appreciate you input & expert Joomla! eye

[eileenmcnaughton]

Upped to MOP based on @andrewpthompson responding