Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden tag to search extension #17789

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 11, 2020

Overview

This was a suggestion from @mattwire that we hide the extension from the UI until the styling dependency is resovled.

It seems reasonable to me as this is primarily in the civicrm-core repo for code management purposes and
making it too easy to enable before the styling is resolved could lead to confusion.

I would quite like to enable on buildkit builds just for dev visibility - but that is something to think
about

Before

New search extension is visible to be enabled in extension ui - however, it dieplays poorly for non-shoreditch users

After

Not visible in the UI - this is proposed to be the case until the above is resolved

Technical Details

Comments

This was a suggestion from @mattwire that we hide the extension from the UI until the styling dependency is resovled.

It seems reasonable to me as this is primarily in the civicrm-core repo for code management purposes and
making it too easy to enable before the styling is resolved could lead to confusion.

I would quite like to enable on buildkit builds just for dev visibility - but that is something to think
about
@civibot
Copy link

civibot bot commented Jul 11, 2020

(Standard links)

@colemanw
Copy link
Member

How would one enable the extension if it's hidden?

I'm wondering if there's an alternative that would make it clear it's a beta... like changing the version number to 1.0.beta1 and adding a disclaimer to the description. That way admins would be able to see it but also know right away that it's not ready for prime-time and they should only enable it for testing purposes.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw only via the API - I think we need to go with that for now & try to fast track resolving the boostrap blocker - which has also been a major afform adoption blocker.

Remember if it were an extension it would only be UI downloadable if apprroved for download.

If the bootstrap gets too sticky we can consider making it ui-visible for those with shoreditch enabled but let's see if we actually can't find a way past the ongoing blocker first

@seamuslee001
Copy link
Contributor

I'm going to merge this as I think this makes some sense to me given the state of the extension

@seamuslee001 seamuslee001 merged commit 755efeb into civicrm:master Jul 13, 2020
@seamuslee001 seamuslee001 deleted the search branch July 13, 2020 00:53
@eileenmcnaughton
Copy link
Contributor Author

Thanks @seamuslee001 - I think this makes it clear that the review process takes point at the time when it is unhidden (as opposed to the point at which the repo is created / it's added to core) - this is inline with other extensions so it's kind of like it still has to go through extension hurdles to become a UI-installable extension & then core hurdles to become always-enabled. We were never looking to bypass those things - only to administer the code in the repo where it will eventually live.

@colemanw let's keep momentum on the css as it is also the main blocker of afform adoption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants