Add hidden tag to search extension #17789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This was a suggestion from @mattwire that we hide the extension from the UI until the styling dependency is resovled.
It seems reasonable to me as this is primarily in the civicrm-core repo for code management purposes and
making it too easy to enable before the styling is resolved could lead to confusion.
I would quite like to enable on buildkit builds just for dev visibility - but that is something to think
about
Before
New search extension is visible to be enabled in extension ui - however, it dieplays poorly for non-shoreditch users
After
Not visible in the UI - this is proposed to be the case until the above is resolved
Technical Details
Comments