Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed notice error on Relationships report #17787

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Fixed notice error on Relationships report #17787

merged 1 commit into from
Jul 11, 2020

Conversation

pradpnayak
Copy link
Contributor

Overview

Screen Shot 2020-07-11 at 00 52 22

Before

before

After

after

@civibot
Copy link

civibot bot commented Jul 10, 2020

(Standard links)

@civibot civibot bot added the master label Jul 10, 2020
@eileenmcnaughton
Copy link
Contributor

Thanks @pradpnayak - is this a regression? I think maybe the rc?

@eileenmcnaughton
Copy link
Contributor

Ok - I dug around & no evidence of recent code changes so I think master is OK

It would be nice to clean these cases on undefined type out but this is a standardisation so I gave it 'ok without test'

@eileenmcnaughton eileenmcnaughton merged commit 93612ea into civicrm:master Jul 11, 2020
@pradpnayak pradpnayak deleted the REF-1 branch September 10, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master ok-without-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradpnayak @eileenmcnaughton