dev/core#1847 Fix datepicker to respect the searchDate offsets #17762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton 3 test failures relate |
eileenmcnaughton
commented
Jul 6, 2020
CRM/Core/Form.php
Outdated
| */ | ||
| public function &add( | ||
| $type, $name, $label = '', | ||
| $attributes = '', $required = FALSE, $extra = NULL | ||
| $attributes = [], $required = FALSE, $extra = NULL |
There was a problem hiding this comment.
@seamuslee001 I think this makes sense for the test fails... it just gets otherwise converted & it's pretty nasty defaulting an array to a string
|
Added has-test since clearly hitting test fails! |
I have some misgivings about this since I suspect the rationale behind the search offsets was primarily about the clunky UI. Having said that I think the datepicker UI is a bit clunky on this front too as it's not obvious you can choose earlier dates. This does at least restore established behaviour. https://lab.civicrm.org/dev/core/-/issues/1847
|
OK - this is probably more conservative - will it pass now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This restores previous behaviour where search datepicker fields had date ranges bounded by the values configured on the date preferences screenn
Before
(with default range of 20 years offset in either direction)
After
(with default range of 20 years offset in either direction)
Technical Details
The min and max year are from civicrm_preferences_date table
Comments
I have some misgivings about this since I suspect the rationale behind the search offsets was primarily about the clunky UI.
Having said that I think the datepicker UI is a bit clunky on this front too as it's not obvious you can choose earlier
dates. This does at least restore established behaviour.
https://lab.civicrm.org/dev/core/-/issues/1847
ping @colemanw @seamuslee001 @mattwire @yashodha