Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventcart shell #17741

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 2, 2020

Overview

This adds the shell of the event cart extension - at this stage it's purely civix generated and is a component portion of
#17508

There is a long-standing technical desire to separate core out into a more modular and less interdependent structure. This includes such things are using the same methods available to extensions for parts of core to interact with each other and potentially, eventually, allowing portions of it to be disabled by some sites or even moved out of the core repo to be managed by other maintainers at a different development pace (in some cases this would be part of a obsolescence strategy - e.g the core implementation of PaymentExpress (NZ payment provider) is superceded in the Omnipay extension so the eventual goal of a strategy to extensionize that processor would be for it to no longer be in core or maintained

Before

No steps yet merged towards the goal of separating out event cart

After

A shell extension is not in the ext directory - the various code needs to be moved into this extension and we need routines to enable it. However, the challenges of improving civix to the point where a new extension would pass code style were not trivial and we are treating that as step one.

Technical Details

Generated with the command civix generate:module eventcart --author="CiviCRM" --email="info@civicrm.org"

Comments

Adding the generated code first makes later changes very transparent / reviewable

@civibot
Copy link

civibot bot commented Jul 2, 2020

(Standard links)

@civibot civibot bot added the master label Jul 2, 2020
@eileenmcnaughton eileenmcnaughton force-pushed the eventcart branch 8 times, most recently from 5e2bb00 to a577e5b Compare July 3, 2020 01:05
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @totten looks like this will pass now - yay - this is pure civix !

Next step is to move BAO / tpl files & enable on install / upgrade. At that point we will have the bulk of the straight move done and then @mattwire can PR in all the improvements without ongoing staleness / huge unreviewable PRs.

@seamuslee001 seamuslee001 merged commit 3ac647f into civicrm:master Jul 3, 2020
@seamuslee001 seamuslee001 deleted the eventcart branch July 3, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants