Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API/DAO Metadata - Retain versioning metadata for possible usage in runtime+tooling #17735

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

totten
Copy link
Member

@totten totten commented Jul 2, 2020

Overview

This is an excerpt from #17729. It makes available more metadata to indicate when fields were created.

Before

In xml/schema/**, there is information about when fields were created. However, this information is not passed through to the DAOs - so it cannot be presented at runtime.

After

The metadata is part of the DAO's fields() tree.

Comments

I extracted this from #17729 because (a) this part is large and prone to growing stale and (b) there are a few different things going on in the original PR, and it may take a bit longer to sort the functional changes. However, this part seems like very low-hanging fruit.

Additionally, the metadata may have multiple uses (e.g. improving the docs which are built into the API Explorer).

@civibot
Copy link

civibot bot commented Jul 2, 2020

(Standard links)

@civibot civibot bot added the master label Jul 2, 2020
@colemanw
Copy link
Member

colemanw commented Jul 2, 2020

This doesn't do anything by itself, it's practically a NFC. Should be safe to merge on pass.

@eileenmcnaughton eileenmcnaughton merged commit 2717c63 into civicrm:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants