Remove obsolete function formatWikiURL

[colemanw]

Overview

Remove obsolete, unused function to create links to our long-dead wiki.

Before

Function exists

After

Gone

Technical Details

It was actually used in 1 place, but the usage made no sense to me, and I'm not sure if the code was even reachable.

Comments

@demeritcowboy would you mind taking a look at the case report to see if the function was as misapplied as I think it was?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Sure will take a look.

[demeritcowboy]

• Currently, a custom field of type link for an activity comes out looking like this if you do print report on manage case:

• When viewing the case activity it looks like this:

• and clicking the link goes to: /civicrm/case/activity/<a (It seems ok for non-case activities.)

• With the patch, it comes out looking like this on print report:

• And like this on the view case activity:

• So it's an improvement and in terms of removing the function that seems right.

• And then beyond that I'd say it's out of scope but there should probably be a purify somewhere, and/or just don't call CRM_Core_BAO_CustomField::displayValue() for type Link, which is where the value ends up getting link-ified. The getCustomData() and getActivityTypeCustomSQL() functions are weird, so it could end up being a mini-project to work through them.

[colemanw]

Thanks. Sounds like this is good to go, and as always, there's more to be done...