dev/core#1817 - Editing a custom field option value from the custom field admin screen changes the name field

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1817

1. Create a custom field that has a choice list, like a select field.
2. Add some options. Save the field.
3. Go to the custom field admin screen where you can edit one of the option values. The screen I'm talking about has a url like /civicrm/admin/custom/group/field/option?reset=1&action=browse&fid=18&gid=7. Administer - Customize Data and Screens - Custom Fields - View and Edit Custom fields - Edit Multiple Choice Options.
4. Edit one of the option choices and change the label. Save it.
5. If you look in the database or use api explorer to do optionvalue get for the option value, you'll see the name field has changed.

Note that if you edit the option from Administer - System Settings - Option Groups, it's a different form and it works ok.

Before

name field gets changed so you need to edit your code whereever you use name to access it whenever the label is changed.

After

name only gets set for new option values

Technical Details

I think there are two separate forms to do the same thing because of history. A future todo might be to consolidate and figure out what else one might be doing that the other isn't doing.

Comments

Has test.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I've reviewed the code and run this and the fix looks good.

I'd 100% support consolidating the two different option edit forms. Agree that it was a historical thing to have two of them. Fun fact - there used to be a third until I got rid of it.

[demeritcowboy]

Thanks!

"Happiness comes in many forms"

[colemanw]

I think happiness can also come from deleting forms :)