[REF] Fix PHP7.4 Test fails when we are accessing array keys when the… #17649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value is not an array
|
(Standard links)
|
seamuslee001
commented
Jun 18, 2020
| @@ -2049,7 +2049,7 @@ public function whereClause($isForcePrimaryEmailOnly = NULL) { | |||
| $this->_params[$id][1] | |||
| ); | |||
| $this->_qill[0][] = ts("%1 %2 %3", [ | |||
| 1 => $field['title'], | |||
| 1 => $field['title'] ?? '', | |||
There was a problem hiding this comment.
this is set to NULL in L2044 if the $this->_fields doesn't contain an id key
seamuslee001
commented
Jun 18, 2020
| $contact2 = $this->individualCreate(['custom_' . $createdField['id'] => $contact1['id']]); | ||
|
|
||
| $this->assertEquals($contact1['display_name'], CRM_Core_BAO_CustomField::displayValue($contact2['id'], $createdField['id'])); | ||
| $contact2 = $this->individualCreate(['custom_' . $createdField['id'] => $contact1]); |
There was a problem hiding this comment.
individualCreate() returns an id not an array
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… value is not an array
Overview
This aims to fix a couple of unit tests that fail on PHP 7.4 because we are using array access on values that are either NULL or an Integer
Before
Tests fail on PHP7.4
After
Tests pass on PHP7.4
tests affected are: