Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price Field Form: save the fid for the postProcess hook #17639

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Jun 16, 2020

Overview

When customizing the Price Field form (i.e. new Price set -> new price field), extensions implementing the postProcess hook cannot handle new fields, since the fid is not set in the form.

This is only visible when adding a new price field, not when editing an existing field.

Before/After

With this PR, extensions can do extra processing in a postProcess (ex: handle a field that was added to the interface).

Comments

Related PRs: #17516 , #17514

@civibot
Copy link

civibot bot commented Jun 16, 2020

(Standard links)

@civibot civibot bot added the master label Jun 16, 2020
@eileenmcnaughton
Copy link
Contributor

@mlutfy Can you add a comment noting this makes it available to the hooks?

@mlutfy
Copy link
Member Author

mlutfy commented Jun 16, 2020

Good point, done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants