dev/core#1433 - Replace last instances of calls to CRM_Case_XMLProcessor::allActivityTypes()

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1433

Follow on from #17614. These are the last instances.

Technical Details

Function doesn't do caching right, but it's just a wrapper around a function that does, so call that function instead.

Also the & isn't needed in createActivity() since the variable is never updated.

Comments

The added test is for something unrelated because there's already good test coverage for createActivity(), and that gets called every time you create a case with a timeline. And there's some coverage already for populateCaseReportTemplate in CRM_Case_XMLProcessor_ReportTest.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks!