Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Update mocking to use getMockBuilder instead instead of createMock #17606

Merged
merged 1 commit into from
Jun 14, 2020
Merged

[NFC] Update mocking to use getMockBuilder instead instead of createMock #17606

merged 1 commit into from
Jun 14, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

Uses standard getMockBuilder instead of CreateMock in unit tests

Before

Tests fail on PHP7.4

After

Tests pass on PHP7.4

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jun 14, 2020

(Standard links)

@civibot civibot bot added the master label Jun 14, 2020
@seamuslee001 seamuslee001 merged commit 03e3335 into civicrm:master Jun 14, 2020
@seamuslee001 seamuslee001 deleted the php74_mock branch June 14, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton