REF Access the method not the property directly to check if a payment processor supports recurring

[mattwire]

Overview

We have access to the payment processor object and should check the method rather than the metadata directly to see if the processor supports recurring. A processor can override the supportsRecurring() and could choose to return different values based on context.

Before

Property accessed directly.

After

Method accessed (which by default reads the property).

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

OK - this supportsRecurring function returns 'is_recur' if not overridden

  /**
   * Checks if payment processor supports recurring contributions
   *
   * @return bool
   */
  public function supportsRecurring() {
    if (!empty($this->_paymentProcessor['is_recur'])) {
      return TRUE;
    }
    return FALSE;
  }

So this should have no impact unless a processor choses to override it. I didn't find instances of extensions that DO override it in a quick check (Omnipay, Iats) which makes sense as it has not been an integral part of our system & was added as part of a membershipType form cleanup.

I think this is pretty safe. Merging