Fix retrieving MySQL version for checking as part of install requirem… #17593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
6bccb57 to
b18689e
Compare
b18689e to
66c0d0b
Compare
|
I applied this on the demo sites job and confirmed it fixes the issue on the demo sites https://test.civicrm.org/job/demo.civicrm.org/BLDNAME=d8-master,label=www-demo/2226/console |
totten
reviewed
Jun 13, 2020
| @@ -307,7 +307,8 @@ public function checkMysqlVersion(array $db_config) { | |||
| return $results; | |||
| } | |||
|
|
|||
| if (version_compare($info, $min) == -1) { | |||
| $versionDetails = mysqli_query($conn, 'SELECT version() as version')->fetch_assoc(); | |||
There was a problem hiding this comment.
IMHO, it makes perfect sense to use SELECT version() for this.
I asked Seamus what was wrong the previous lookup - he pointed out that mysqli_get_server_info() for MariaDB reports weird values: https://www.php.net/manual/en/mysqli.get-server-info.php#118822
So this change makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ents
Overview
This fixes a bug that comes on some MariaDB instances where by the version maybe 10.2 but it gets reported via the mysqli_info as 5.5.5-10.2. This is presently happening on our demo sites
"ERROR: (database) CiviCRM MySQL Version: MySQL version is 5.5.5-10.2.32-MariaDB-10.2.32+maria~stretch; minimum required is 5.6.5"
Before
MySQL DB information doesn't always work correctly for us
After
Correct version returned
ping @eileenmcnaughton @mlutfy