Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table

[eileenmcnaughton]

Overview

Rc fix for performance regression in deduping - note I want to see if we can do a better fix onn master

Before

SQL runs:

select id FROM civicrm_financial_item WHERE entity_table = 'civicrm_contact'; to see if the table is a dedupe candidate.

However, the index on this table does not cover the where clause & as this is a large table it gets slow

After

Query hacked out of the list

Technical Details

For the 'real' fix on master I think we want a schema for this - ie something like

--- a/xml/schema/Financial/FinancialItem.xml
+++ b/xml/schema/Financial/FinancialItem.xml
@@ -130,9 +130,11 @@
     <name>entity_table</name>
     <type>varchar</type>
     <title>Entity Table</title>
+    <required>true</required>
     <length>64</length>
     <comment>The table providing the source of this item such as civicrm_line_item</comment>
     <add>4.3</add>
+    <validTables>civicrm_line_item, civicrm_financial_trxn</validTables>
   </field>
   <field>
     <name>entity_id</name>

Note there is a previous pointer to this approach

civicrm-core/CRM/Core/DAO.php

Line 2407 in 449c4e6

* TODO: filter dynamic entity references on the $tableName, based on

Comments

@totten @seamuslee001 @colemanw a couple of questions

1. How do we want the xml to look for specifying valid tables for civicrm_entity
2. Does this need to be in regen / go into the DAO ?
3. Should it be hookabale?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

unused

[eileenmcnaughton]

Just thinking on the 'right fix' - perhaps DAO generate should put an array rather than NULL into the table, if in the xml

[eileenmcnaughton]

SO I'm thinking that we

1. agree an xml syntax for allowed tables
2. update the DAO generator to put an array of tables rather than NULL
3. fix Core_Reference_Dymnamic to cope with an array if present

@totten are you OK with ^^

[seamuslee001]

We discussed this in core team meeting and Tim was ok with this as an interim solution merging