dev/financial#131 Fix Realex processor to correctly throw an exception #17559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Jun 9, 2020
| $hashme = "$sha1hash.{$this->_getParam('secret')}"; | ||
| $sha1hash = sha1($hashme); | ||
|
|
||
| if ($response['SHA1HASH'] != $sha1hash) { |
There was a problem hiding this comment.
No content in this if - so lines above also do nothing
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix Realex processor to correctly throw an exception as part of our push to model best practice in core processors
Before
returns a core error - relies on parent to convert it
After
throws a PaymentProcessorException
Technical Details
https://lab.civicrm.org/dev/financial/-/issues/131 & parent issues
Comments