Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove instances of fatal from upgrade folder #17534

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Remove instances of fatal from upgrade folder #17534

merged 1 commit into from
Jun 7, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove instances of fatal from upgrade folder

Before

   CRM_Core_Error::fatal($errorMessage);

After

      throw new CRM_Core_Exception($errorMessage);

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 7, 2020

(Standard links)

@civibot civibot bot added the master label Jun 7, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit 0a83e29 into civicrm:master Jun 7, 2020
@eileenmcnaughton eileenmcnaughton deleted the fatal2 branch June 7, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001