Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommunityMessages - Define more consistent behavior in the face of slow execution #17529

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

totten
Copy link
Member

@totten totten commented Jun 6, 2020

Overview

The CommunityMessagesTest is producing failures with TIME_FUNC option of linear:500 (the value currently used in PR test runs) -- which is to say, it fails when the system runs very slowly (with some 500ms stalling during execution).

This gets it working under some brutally slow scenarios:

for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
  export TIME_FUNC;
  echo;
  echo "TIME_FUNC=$TIME_FUNC" ;
  env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Core/CommunityMessagesTest.php ;
done

…ow execution

This passes under some brutally slow scenarios:

```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
  export TIME_FUNC;
  echo;
  echo "TIME_FUNC=$TIME_FUNC" ;
  env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Core/CommunityMessagesTest.php ;
done
```
@civibot
Copy link

civibot bot commented Jun 6, 2020

(Standard links)

@civibot civibot bot added the 5.27 label Jun 6, 2020
@seamuslee001
Copy link
Contributor

looks good to me and the specific tests pass

@seamuslee001 seamuslee001 merged commit 7f9acf5 into civicrm:5.27 Jun 7, 2020
@totten totten deleted the 5.27-comm-msg branch June 7, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants