Disable frequency/interval fields if not required. Mark required if they are so they are validated before submit

[mattwire]

Overview

Support js validation on frequency interval field on frontend contribution page

Before

No jquery validation on frequency interval on frontend contribution page.

After

jquery validation works. Fields are disabled when not required:

Technical Details

If the "i want to contribute this amount every" checkbox is checked then the frequency interval is a required field. But it's not marked as required so only fails validation on the php side once the form is submitted.

Comments

Related issue #16495

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I haven't tested but this seems sensible - can we use meaningful names though - it's a lot easier to understand frequencyUnit than frUnit

[mattwire]

@eileenmcnaughton There is similar code elsewhere (for backend forms) so I just copied the variables. Have updated now per suggestion

[eileenmcnaughton]

@jaapjansma if you are still going this is good IMHO from a code & concept POV - if you get a chance to -run I'm happy to merge this one (or for Matt to do so based on a thumbs up from you or anyone else who r-runs it)

[jaapjansma]

@mattwire this PR has conflicting files. Could you please fix this?

[mattwire]

@jaapjansma Thankyou - I've rebased

[eileenmcnaughton]

I tested this & was able to replicate it - it was pretty confusing because there IS validation that shows regardless - it's just some of it is jquery (& hence faster)