dev/core#1798 - "End of yesterday" Relative Date Filter

[semseysandor]

Overview

GitLab Issue

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins add to whitelist

[eileenmcnaughton]

@magnolia61 @MegaphoneJon is either of you able to test this.

Note this is a first-time contributor - so thank you @semseysandor & I'll spare you my push on unit tests this round :-)

[semseysandor]

@eileenmcnaughton It's OK, I've added the tests as well

[eileenmcnaughton]

Ohh - well done!

[eileenmcnaughton]

@semseysandor looks like you have some style warnings picked up by jenkins - if you click on the red x above you should see them.

[jaapjansma]

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR.
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: We followed the description given in the lab issue.
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
  • Test results (r-test)
    • PASS: The test results are all-clear.

@eileenmcnaughton @seamuslee001 could one of you merge this PR?

@semseysandor Thanks for your PR and thanks for all your hard on it including adding a test and well described issue on how to reproduce it!!