Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait #17511

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Jun 5, 2020

Overview

This adds helper functions and properties to frontendpaymentformtrait for isBackOffice(), isPayLater() and get/SetPaymentMode() so we don't have to interact directly with the properties and do not have to specify them on each form.

Developed for #17508

Before

Direct access to properties, they must be specified on each form.

After

Just use frontendpaymentformtrait and the new methods.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 5, 2020

(Standard links)

@civibot civibot bot added the master label Jun 5, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

I agree with this change - let's see the warning fix & check tests pass & then I think it should be OK to merge.

You could possibly deprecate $_mode - but then I think you'd need another undeprecated protected property that would also be set & returned. We have tried that elsewhere - with some degree of success (non-blocking feedback)

@mattwire mattwire force-pushed the paymentprocessoraddfrontendfunctions branch from 2b787de to 6a2b3da Compare June 6, 2020 13:50
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit 26815ac into civicrm:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants