Payment PropertyBag - Fix setAmount

[mattwire]

Overview

This is quite a serious issue as it causes the amount to be set incorrectly on propertybag because the params are the wrong way around.

Before

Params switched so setAmount doesn't set amount correctly.

After

Amount set correctly on propertybag.

Technical Details

Comments

@eileenmcnaughton @artfulrobot Can you check please - we really need to get this in asap (before the 5.27 RC is cut as it causes the amount to be set incorrectly on propertybag.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[artfulrobot]

Yes! Let's merge ASAP! I spotted this one when I was to busy/stressed to focus and couldn't remember what it was. Thanks

[eileenmcnaughton]

It's not a change in this PR - but what format are we actually returning here? Ideally a non-localised format but I have doubts...

[mattwire]

@eileenmcnaughton I think it's actually a localized numeric because it's passed through money_format. So we should change that. We should also consider whether we want to store this internally in propertybag as a string or without decimal point (ie. EUR30.12 = 3012) as is recommended when dealing with monetary values.

[eileenmcnaughton]

@mattwire I think we should definitely switch to non-formatted

Re best format - I think we should add a php library & store as a money object per https://lab.civicrm.org/dev/translation/-/issues/48