[Ref] Throw exceptions from Authorize.net rather than return errors

[eileenmcnaughton]

Overview

This is part of 'modelling good behaviour' - curently doPayment converts the errors to thrown exceptions,
but the recommendation is that the payment processor functions should throw exceptions themselves.
If they do they willl bypass the doPayment handling, but acheive the same thing

Before

return self::error(9001, 'Payment interval must be at least one week');

is received by CRM_Core_Payment::doPayment and which then throws an exception

After

Exception thrown in the first place

Technical Details

@KarinG basically we need to do this in a bunch of places - in core & also encourage extension writers to do so.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[KarinG]

Right - I started replacing the self::error (for iATS) with:

throw new CRM_Core_Exception

but I'll change that to

throw new PaymentProcessorException

Learning something every day :-)

[eileenmcnaughton]

Yep - it would probably work the same but the latter is better form

[seamuslee001]

won't calling functions potentially miss error messages?

[eileenmcnaughton]

doRecurPayment won't return an error now - it will throw exceptions

[seamuslee001]

changes seem fine to me