Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remaining Authorize.net test to use guzzle #17473

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Convert remaining Authorize.net test to use guzzle #17473

merged 1 commit into from
Jun 4, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This allows us to remove the handling for when a.net doesn't reply

Before

Test dependency on external services, flakey

After

Mocks requests

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 2, 2020

(Standard links)

@civibot civibot bot added the master label Jun 2, 2020
@seamuslee001
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

@eileenmcnaughton test fail relates https://test.civicrm.org/job/CiviCRM-Core-PR/34440/testReport/junit/(root)/CRM_Core_Payment_AuthorizeNetTest/testCreateSinglePostDated/

@eileenmcnaughton
Convert remaining Authorize.net test to use guzzle
31c873b 
This allows us to remove the handling for when a.net doesn't reply
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001 seamuslee001 merged commit cff1a9a into civicrm:master Jun 4, 2020
@seamuslee001 seamuslee001 deleted the anet branch June 4, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001