Add actual field name for processor_id to getSubscriptionDetails

[mattwire]

Overview

In some places in the code (notably parts of cancelSubscription) civicrm_contribution_recur.processor_id is renamed to subscription_id. This retrieves it as processor_id as well so that we can reduce the confusion one day!

Before

In some places you have to access processor_id via subscription_id

After

In more places you can directly access processor_id.

Technical Details

Comments

@seamuslee001 This should help clarify #17461 a little bit

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

OK - I think it's hard to see why we introduce subscriptionId as another name for the field here.