dev/core#1782 Set activity_date_time and created_date to default to current_timestamp

[mattwire]

Overview

Add defaults for activity_date_time and created_date if not set.

Before

No default.

After

Default

Technical Details

Comments

Found via #17274

@seamuslee001 I think we might need an upgrader step too so the database gets the defaults defined?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I think the tests will do a good job of finding any issues here. Once the upgrade change is in too then then I'm happy when jenkins is (MOP was premature as the upgrade change not in yet)

[seamuslee001]

The failure was

mysql: [Warning] Using a password on the command line interface can be insecure.
ERROR 1064 (42000) at line 4202: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DEFAULT CURRENT_TIMESTAMP COMMENT 'Date and time this activity is scheduled to o' at line 8

Also note this

"Previously, at most one TIMESTAMP column per table could be automatically initialized or updated to the current date and time. This restriction has been lifted. Any TIMESTAMP column definition can have any combination of DEFAULT CURRENT_TIMESTAMP and ON UPDATE CURRENT_TIMESTAMP clauses. In addition, these clauses now can be used with DATETIME column definitions. For more information, see Automatic Initialization and Updating for TIMESTAMP and DATETIME."

https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html So this would break anyone who was trying to install on MySQL 5.5 (no of course deprecated but we still permit installation on it)

[eileenmcnaughton]

@colemanw any thoughts?

[colemanw]

It sounds like we'll have to drop support for MySql 5.5 before releasing this.
That's fine with me but the question is how much lead time or warning should we give?
Looks like only last month we bumped the minimum from 5.1 to 5.5!
According to http://stats.civicrm.org/?tab=technology most sites are already up to or beyond 5.6, with about a thousand sites still running 5.5 (those same sites may well be running an older version of Civi as well).

[colemanw]

@mattwire the DAO still needs regen.
We'll also need to put in some upgrade sql but need to pick a target version first.
If we merge this in June then it goes into the RC in July and released in August; we'd just need to put the word out btw now and then that we are dropping 5.5 support.
We should also bump up CRM_Upgrade_Incremental_General::MIN_INSTALL_MYSQL_VER as part of this PR.

[colemanw]

Ref https://lab.civicrm.org/dev/core/-/issues/1681

[eileenmcnaughton]

We discussed this & plan is remove mysql 5.5 support in 5.28 - so with some test changes & changes to support that we will be able to merge this

[mattwire]

@colemanw @eileenmcnaughton I've added the upgrader and the min SQL version. And regenerated DAO. Are we good to merge?

[colemanw]

Looks great!

[eileenmcnaughton]

I removed the ready for review as this is stale. I'm not a fan of the label since in theory they should all be if they are in the review queue

[mattwire]

@colemanw This is now rebased following DAO updates.

[eileenmcnaughton]

If this doesn't pass it might be that we need to adjust CI - @seamuslee001 emailed the dev list to highlight that we will discontinue 5.5 mysql support

[eileenmcnaughton]

nice!

[colemanw]

Nice work everyone. And thanks for the followups #17496 and #17558 @seamuslee001