Make 'Pending' the default status for Contribution.repeattransaction

[mattwire]

Overview

As the preferred way to repeat a contribution is now to call Contribution.repeattransaction and then Payment.create it makes sense to set contribution_status_id to Pending by default as that is the preferred way to call this API

Before

Must specify contribution_status_id for repeattransaction.

After

Don't need to specify it. When implementing functionality using Contribution.repeattransaction it is obvious that the intended way to call it is with status=Pending.

Technical Details

Just sets default at API level. As this is a required parameter it won't affect any existing implementations as they will all specify the contribution_status_id as a parameter.

Comments

@eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

OK - agreed & it won't break existing as they will pass in a default