Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reCAPTCHA settings clearer #17426

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented May 30, 2020

Overview

Make the reCAPTCHA settings a bit clearer:

  • Capitalise consistently.
  • Explicitly state that it is "v2 Checkbox" because you need specific keys and it didn't actually say that anywhere!

Before

image

After

image

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 30, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@MikeyMJCO any thoughts on this? The only part that seems less clear to me is the changing of the word 'keys' to 'checkbox'

@homotechsual
Copy link
Contributor

@MikeyMJCO any thoughts on this? The only part that seems less clear to me is the changing of the word 'keys' to 'checkbox'

Agreed, I'd probably say this should be left with the title as "Recaptcha v2" or "Recaptcha v2 Settings".

Move the clarification that you need the specific settings for v2 checkbox to the paragraph below and/or highlight in the docs.

@mattwire
Copy link
Contributor Author

mattwire commented Jun 1, 2020

@MikeyMJCO @eileenmcnaughton Done - see updated screenshot.

@eileenmcnaughton eileenmcnaughton merged commit 856dfbd into civicrm:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants