Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove unreachable block. #17407

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This code was duplicated onto this form for cleanup. Since this is the
renewal form there should always be a current membership. I haven't removed the IF yet
for readability but that would follow on

Before

Unreachable code present

After

poof

Technical Details

Test cover is in CRM_Member_Form_MembershipRenewalTest

Comments

This code was duplicated onto this form for cleanup. Since this is the
renewal form there should always be a current membership. I haven't removed the IF yet
for readability but that would follow on
@civibot
Copy link

civibot bot commented May 27, 2020

(Standard links)

@civibot civibot bot added the master label May 27, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@yashodha
Copy link
Contributor

@eileenmcnaughton looks good to merge

@seamuslee001 seamuslee001 merged commit baadb22 into civicrm:master May 27, 2020
@seamuslee001 seamuslee001 deleted the recur branch May 27, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants