[REF] duplicate function.

[eileenmcnaughton]

Overview

This seems like the opposite of good principles but I've found that when facing a nasty chunk of code it's
often better to copy it & then start to clean it up, knowing that other places are not affected & not
having as much complexity to deal with

Before

Function shares

After

Membership recur form to 'got it alone' - no cleanup or change as yet

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton checkstyle.. Also what is your plan here? This is a pretty big function that is called a lot! I'm not sure I see the benefit vs. cleaning it up in place. This function usually gets hit whenever I'm looking into membership issues too.

[eileenmcnaughton]

@mattwire it's just too hard to clean up in place - there is too much going on & this is the simple use case whereas the front end form usage is complex.

About 50% of the function can probably be ripped out in the first round as I believe this line

https://github.com/civicrm/civicrm-core/pull/17400/files#diff-349ca8bcf1ef264bf3ca9acc2593aa54R768

should always be true.

In essence what the function does is mostly come up with an array to pass to Membership::create so it's just a case of untangling that

[mattwire]

@eileenmcnaughton Test failures relate