Don't exclude deleted contacts from ACL cache when user has permission #17379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…mission to see them Test failures seem to be due to assumptions of the test. Removed via Hume's guillotine When the user has 'access deleted contacts' permission, deleted contacts should not be excluded from the ACL cache.
|
The only test failures were IMO due to faulty assumptions. Per Hume's guillotine, just because the SQL string does look like that, doesn't mean it ought to. |
|
@eileenmcnaughton you're probably best for reviewing this one |
|
This makes sense. I agree it seems like a coding error |
|
This seems to affect basic and advanced contact search as reported at https://lab.civicrm.org/dev/core/-/issues/1864. They both always return deleted contacts now. |
|
Ok, so we need to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When the user has 'access deleted contacts' permission, deleted contacts should not be excluded from the ACL cache.
Before
Deleted contacts excluded from ACL cache even when user has permission to see them.
After
Deleted contacts only excluded when user lacks permission to see them.
Comments
The code comment mentioned https://issues.civicrm.org/jira/browse/CRM-6181 which is only tangentially related, which leads me to think this was simply a coding error that never got caught.