Remove $_REQUEST passed into CRM_Utils_Request::retrieve NFC

[artfulrobot]

This is a subset of #17324

A lot of code called CRM_Utils_Request::retrieve or CRM_Utils_Request::retrieveValue with the wrong value type for it's $method which is supposed to be a String, but in dozens of places code was passing the $_REQUEST Array. The retrieve method is and was coded with a switch that checks on strings 'POST' and 'GET', and in all other cases (e.g. an array!), it defaulted to $_REQUEST - so serendipity has served us well! In these cases I have simply removed that param since it's the default behaviour anyway.

This PR only contains such changes and as a result should make no difference; it's a NFC

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[artfulrobot]

What does this code even do?

Line 31 fetches 'cid' from POST, failing that, GET, failing that from $self->get('cid').

Then if that fails, we try again, but without $self->get('cid')? But we know that will yield the same results anyway, no?

[colemanw]

These four lines starting with if (!$contactId) { look pointless to me.

[artfulrobot]

I've done more of a clean up, removing other default params.

[mattwire]

@artfulrobot There is now a test failure, I don't know if it is related?

[artfulrobot]

Interesting, I'll take a look

[artfulrobot]

Jenkins please test this.

(that failed test passes repeatably on my buildkit)

[mattwire]

@artfulrobot Still failing :-(

[artfulrobot]

What do you do when you can't reproduce a test fail locally?! Any tips?

[artfulrobot]

Jenkins please test this.

If at first you don't succeed, try try again...

[mattwire]

Let's merge this quick before it fails again ;-)