[TEST] Fix test failure on Drupal 8 E2E PrevNextTest by only includin… #17358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g contacts where there is a sort name
|
(Standard links)
|
|
I'm OK to merge this but we do need to be careful because in the past the 'different in different environment' bugs have sometimes been 'real live bugs' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g contacts where there is a sort name
Overview
The issue here 2 fold 1) the order of the contacts as they are cached is different when running in different cmses and 2) the sort_name doesn't get populated for the admin user (i suspect because of the lack of the sync for users but maybe not) however this change I don't think alters the substance of the test at all
Before
Test fails on Drupal 8
After
Test passes on Drupal 8
ping @totten @eileenmcnaughton