Fix for dev/core#1608: correct date format for trxn_date. #17355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@twomice - the change makes sense - is it still WIP? |
|
@eileenmcnaughton this fix works for me, and is only WIP because I'm looking for passing tests before calling it a "real" PR. Don't know why it says "Some checks haven’t completed yet", as it looks like all tests are passing. I'll test again. |
|
Jenkins test this please. |
|
@eileenmcnaughton All tests are passing. I've removed the "WIP" prefix. Are you able to merge or is more needed from me? |
|
This looks like a sensible change to me, Tests have passed so going to merge |
|
Thanks @seamuslee001 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Aims to fix Recurring contribution fails with "ipn_payment_callback_exception", for membership auto-renewal via PayPalPro by correcting date format for the
$input['trxn_date']parameter.Before
Automatic membership renewal payments, when received as IPN messages for PayPal Pro, fail with exception message "Oops, it looks like there is no valid membership status corresponding to the membership start and end dates for this membership. Contact the site administrator for assistance."
After
IPN notifications are processed successfully.
Technical Details
Please see long explanation in the first comment of the referenced issue.
Comments
Currently WIP, looking to see test results.