Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instantiation of transaction from payment express ipn class #17348

Merged
merged 1 commit into from
May 25, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview
Minor code cleanup

Before

PaymentExpressIPN calls parent::completeTransaction

After

PaymentExpressIPN calls the function that the parent calls, without needlessly instantiating the transaction

Technical Details

This class is hopefully unused, however, this change should be safe regardless as it just calls the same function
without needlessly instantiating the transaction

Note this processor is not enabled on install or recommended

Comments

This class is hopefully used, however, this change should be safe regardless as it just calls the same function
without needlessly instantiating the parent.

Note this processor is not enabled on install or recommended
@civibot
Copy link

civibot bot commented May 18, 2020

(Standard links)

@civibot civibot bot added the master label May 18, 2020
@mattwire mattwire merged commit 8fd7748 into civicrm:master May 25, 2020
@eileenmcnaughton eileenmcnaughton deleted the payex branch May 25, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants