Call completeOrder directly from contribute status update form

[eileenmcnaughton]

Overview

Minor code simplification

Before

Base IPN class being used to complete order

After

completeOrder called directly - this is intended as transitional with an api call being the end goal. However, it does start to clarify the use of the $transaction variable

Technical Details

We should really call completetransaction but that has been left for later unravelling with the focus here being
to clarify the purpose of the transaction. We don't need to pass a transaction around unless it has DB changes not
yet committed - which is not eally the case here. There is no reason to invoke BaseIPN but more unravelling required...

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Changes look good to me and tests have passed merging