Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Call completeOrder directly from event status update form #17346

Merged
merged 1 commit into from
May 21, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 18, 2020

Overview

Minor code cleanup

Before

Instantiate transaction just to be able to call a function on an unrelated task

After

Directly call function closer to what we should call

Technical Details

We should really call completetransaction but that has been left for later unravelling with the focus here being
to clarify the purpose of the transaction. We don't need to pass a transaction around unless it has DB changes not
yet committed - which is not eally the case here. There is no reason to invoke BaseIPN but more unravelling required...

Comments

=

We should really call completetransaction but that has been left for later unravelling with the focus here being
to clarify the purpose of the transaction. We don't need to pass a transaction around unless it has DB changes not
yet committed - which is not eally the case here. There is no reason to invoke BaseIPN but more unravelling required...
@civibot
Copy link

civibot bot commented May 18, 2020

(Standard links)

@civibot civibot bot added the master label May 18, 2020
@eileenmcnaughton eileenmcnaughton changed the title Call completeOrder directly from event status update form [REF] Call completeOrder directly from event status update form May 18, 2020
@mattwire mattwire merged commit 2b6973f into civicrm:master May 21, 2020
@eileenmcnaughton eileenmcnaughton deleted the trans2 branch May 21, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants