Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Add comment that deprecated code is actually still reachable #17340

Merged
merged 1 commit into from
May 17, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

I'm not sure I want to take this on so just adding a comment that this deprecation warning is not true in case someone comes along and deletes it. You can reach it by doing a contact import with "related contact" info, e.g. a csv like

First Name,Last Name,spouse-first-name,spouse-last-name,spouse-home-phone
Amy,Jones,Doug,Jones,444-544-6666

@civibot
Copy link

civibot bot commented May 17, 2020

(Standard links)

@civibot civibot bot added the master label May 17, 2020
@seamuslee001
Copy link
Contributor

ping @eileenmcnaughton this seems fine to me but just in case if you had any better ideas

@eileenmcnaughton
Copy link
Contributor

Seems to make the lack of clarity more clear...

@eileenmcnaughton eileenmcnaughton merged commit c7c568a into civicrm:master May 17, 2020
@demeritcowboy demeritcowboy deleted the not-yet-deprecated branch May 19, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants