APIv4 - Remove implicit multi joins & add explicit joins #17332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OptionValue joins were deprecated in favor of pseudoconstant suffixes. This removes them.
|
(Standard links)
|
These were actually run as a separate query and "joined" to the main results array in PHP. Removing them to make way for supporting explicit multi-joins which will use SQL.
This event was defined but never invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes the way joins are done in APIv4.
Before
One-to-many joins were implied using dot notation, which triggered a secondary query to run after the main query.
After
Implicit multi-joins have been removed.
Joins can now be done on any table by explicitly specifying a
joinparam.Implicit one-to-one joins are not affected.