Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_archived work as a url-search parameter #17328

Merged
merged 1 commit into from
May 31, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 15, 2020

Overview

Eg civicrm/mailing/browse/scheduled?reset=1&is_archived=1&force=1

Before

is_archived cannot be passed in the url using our normal url protocol

After

civicrm/mailing/browse/scheduled?reset=1&is_archived=1&force=1 works, other params would work if in metadata

Screen Shot 2020-05-15 at 12 57 17 PM

Technical Details

Ref #16478

Comments

@civibot civibot bot added the master label May 15, 2020
@civibot
Copy link

civibot bot commented May 15, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Jenkins retest this please

@seamuslee001
Copy link
Contributor

@eileenmcnaughton I checked this and i saw that it still wasn't quite being passed to the underlying query but i suspect that that is a problem with this search form given it is different to all the others

Eg civicrm/mailing/browse/scheduled?reset=1&is_archived=1&force=1
@eileenmcnaughton
Copy link
Contributor Author

eileenmcnaughton commented May 25, 2020

@seamuslee001 ok - I've hacked it around - I guess making this screen work with the url was never really the point - the point was to see how this field would convert to metadata, but having framed it around the screen I had to make it work

@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain) Pass
    • (r-user) Pass
    • (r-doc) Pass
    • (r-run) Pass I was able to pass in is_archived=1 and also as 0 as appropriate into the urls and confirmed that it worked correctly with the current search interface
  • Developer standards

@seamuslee001 seamuslee001 merged commit 8b2203a into civicrm:master May 31, 2020
@seamuslee001 seamuslee001 deleted the mailing_seach branch May 31, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants