Comm prefs: add condition param for {privacyFlag}

[agh1]

Overview

This is a follow-up for #17283 that adds a condition parameter for {privacyFlag} to simplify the code a bit and make it work more similarly to {icon}.

In the process, this also displays on hold status alongside do not email status. This was handled inconsistently before (the on hold would take precedence in search results, while the do not email would take precedence on the contact summary). Both pieces of information are also independently useful.

Before

If you want to use {privacyFlag} to show "Do not mail", etc., you need to wrap it in an {if}.

After

You can supply a value as a condition to {privacyFlag}, and it will only display the icon if the value is true.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I like the array_key_exists check for condition. Maybe we should do that for the {icon} as well.

[agh1]

@colemanw it's in there for {icon}:

civicrm-core/CRM/Core/Smarty/plugins/block.icon.php

Line 37 in f4388b5

$condition = array_key_exists('condition', $params) ? $params['condition'] : 1;

The difference is just that CRM_Core_Page::crmIcon() is where the condition is handled.

[agh1]

Found EXITCODES=" sequentialcreditnotes"

Something is breaking with tests recently.

Jenkins retest this please

[eileenmcnaughton]

test this please

[seamuslee001]

Test fails unrelated