Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add contribution_id field to search using metadata instead of h… #17286

Merged

Conversation

seamuslee001
Copy link
Contributor

…ard codeded quickform html

Overview

Follow on from #16484 and this adds the contribution_id field using metadata rather than a hard coded quickform field. Doing it this way also allows for search urls such as /civicrm/contribute/search?reset=1&force=1&contribution_id=1 to be used

Before

Field added using hard coded quickform values

contribution_pre

After

Field added using metadata
contribution_post

ping @mattwire @eileenmcnaughton @yashodha

@civibot
Copy link

civibot bot commented May 10, 2020

(Standard links)

@civibot civibot bot added the master label May 10, 2020
@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users. who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: We have tested the advanced search and find contribution by searching on an existing contribution id. Both in dmaster and in the test site of this PR.
      • ISSUE:
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@eileenmcnaughton or @mattwire could one of you merge this PR?

@mattwire mattwire merged commit 1a1e261 into civicrm:master May 11, 2020
@eileenmcnaughton eileenmcnaughton deleted the contribution_id_search_metadata branch May 11, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants