Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all instances of copy.png with font awesome #17280

Merged
merged 1 commit into from
May 11, 2020

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented May 10, 2020

Overview

This slices off one commit from #17259 for ease of review.

This gets rid of the copy.png icon which appears at the top of columns in the batch edit screens. A new smarty function {copyIcon} takes the field name and title and produces the appropriate markup, including screen reader text.

Before

image

After

image

@civibot
Copy link

civibot bot commented May 10, 2020

(Standard links)

*
* @package CRM
* @author Andrew Hunt, AGH Strategies
* $Id$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This $Id$ should not be added. We are leaning towards skipping the whole block where it is the same as the default (in this case it isn't due to the author tag)

@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable.
    • Documentation (r-doc)
      • ISSUE: The developer documentation should be updated.
      • COMMENTS: It would be nice if the functionality introduced in this PR would be documented in the developer documentation.
    • Run it (r-run)
      • PASS: We checked the update multiple contacts screen in both dmaster and the test site of this PR. We also checked whether the copying of data still worked.
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

Although we advice to update the developer documentation we don't think it is blocking this PR.
@eileenmcnaughton or @mattwire could one of you merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants