CRM/Logging - Remove obsolete cache static clear in test #17269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
ee5b2ae to
2cf2852
Compare
This simplifies CRM_Logging_SchemaTest::testLengthChange() and CRM_Logging_SchemaTest::testEnumChange() by removing a manual reset on a cache static and a second call to CRM_Logging_Schema::fixSchemaDifferences(). This was made obsolete by a40a5a4, which has added a cache flush to fixSchemaDifferences() via fixSchemaDifferencesForAll().
2cf2852 to
70671c3
Compare
|
Applied the change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This simplifies
CRM_Logging_SchemaTest::testLengthChange()andCRM_Logging_SchemaTest::testEnumChange()by removing a manual reset on a cache static and a second call toCRM_Logging_Schema::fixSchemaDifferences()Before
Cache static is cleared by test and
CRM_Logging_Schema::fixSchemaDifferences()is called twice for each schema change.After
No cache manipulation in test code and
CRM_Logging_Schema::fixSchemaDifferences()is called only once.Comments
This was made obsolete by a40a5a4, which has added a cache flush to
fixSchemaDifferences()viafixSchemaDifferencesForAll().ping @totten